Fix build against glibc trunk: getopt #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In file included from /usr/include/bits/getopt_posix.h:27:0, from /usr/include/unistd.h:872, from ../nvptx-ld.c:23: /usr/include/bits/getopt_core.h:91:12: error: declaration of 'int getopt(int, char* const*, const char*) throw ()' has a different exception specifier extern int getopt (int ___argc, char *const *___argv, const char *__shortopts) ^~~~~~ In file included from ../nvptx-ld.c:22:0: ../include/getopt.h:113:12: note: from previous declaration 'int getopt(int, char* const*, const char*)' extern int getopt (int argc, char *const *argv, const char *shortopts); ^~~~~~
|
@jakubjelinek, should the |
|
It is done in libiberty/configure.ac too. The problem is that the toplevel includes the libiberty headers and thus needs the right HAVE_DECL_GETOPT definition when compiling the toplevel sources. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In file included from /usr/include/bits/getopt_posix.h:27:0,
from /usr/include/unistd.h:872,
from ../nvptx-ld.c:23:
/usr/include/bits/getopt_core.h:91:12: error: declaration of 'int getopt(int, char* const*, const char*) throw ()' has a different exception specifier
extern int getopt (int ___argc, char const ___argv, const char __shortopts)
^~~~~~
In file included from ../nvptx-ld.c:22:0:
../include/getopt.h:113:12: note: from previous declaration 'int getopt(int, char const, const char)'
extern int getopt (int argc, char *const *argv, const char *shortopts);
^~~~~~